ddp/books
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improved DB error handling

Browse Source
This commit is contained in:
Damien De Paoli
2020-12-30 23:12:36 +11:00
parent 60b7484afb
commit af6c76d136
5 changed files with 76 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
rating.py
View File

@@ -47,8 +47,9 @@ def ratings():
@app.route("/rating", methods=["GET", "POST"])
def new_rating():
form = RatingForm(request.form)
page_title='Create new Rating'
if 'name' not in request.form:
return render_template("edit_id_name.html", form=form, page_title='Create new Rating' )
return render_template("edit_id_name.html", form=form, page_title=page_title )
else:
rating = Rating( name=request.form["name"] )
try:
@@ -59,7 +60,7 @@ def new_rating():
except SQLAlchemyError as e:
st.SetAlert( "danger" )
st.SetMessage( "<b>Failed to add rating:</b>&nbsp;{}".format( e.orig) )
return render_template("edit_id_name.html", form=form, page_title='Create new Rating', alert=st.GetAlert(), message=st.GetMessage() )
return render_template("edit_id_name.html", form=form, page_title=page_title, alert=st.GetAlert(), message=st.GetMessage() )
################################################################################
# /rating/<id> -> GET/POST(save or delete) -> shows/edits/delets a single rating
@@ -68,6 +69,7 @@ def new_rating():
def rating(id):
### DDP: should this be request.form or request.values?
form = RatingForm(request.form)
page_title='Edit Rating'
if request.method == 'POST' and form.validate():
try:
rating = Rating.query.get(id)
@@ -81,12 +83,12 @@ def rating(id):
return redirect( '/ratings' )
except SQLAlchemyError as e:
st.SetAlert( "danger" )
st.SetMessage( "<b>Failed to modity rating:</b>&nbsp;{}".format(e.orig) )
return render_template("edit_id_name.html", form=form, page_title='Edit Rating', alert=st.GetAlert(), message=st.GetMessage() )
st.SetMessage( "<b>Failed to modify Rating:</b>&nbsp;{}".format(e.orig) )
return render_template("edit_id_name.html", form=form, page_title=page_title, alert=st.GetAlert(), message=st.GetMessage() )
else:
rating = Rating.query.get(id)
form = RatingForm(request.values, obj=rating)
return render_template("edit_id_name.html", form=form, page_title='Edit Rating' )
return render_template("edit_id_name.html", form=form, page_title=page_title )
################################################################################
# Gets the Rating matching id from DB, helper func in jinja2 code to show books