From eab8983f40810edabdf581f5f667c4ad2b2ba697 Mon Sep 17 00:00:00 2001 From: Damien De Paoli Date: Fri, 24 Sep 2021 12:47:47 +1000 Subject: [PATCH] use url_for not hardcoded routes --- person.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/person.py b/person.py index dd4ffd9..337a840 100644 --- a/person.py +++ b/person.py @@ -115,7 +115,7 @@ def new_person(): db.session.add(person) db.session.commit() st.SetMessage( "Created new Person ({})".format(person.tag) ) - return redirect( f'/person/{person.id}' ) + return redirect( url_for( 'person', id=person.id) ) except SQLAlchemyError as e: st.SetMessage( f"Failed to add Person: {e.orig}", "danger" ) return render_template("person.html", person=person, form=form, page_title = page_title) @@ -139,7 +139,7 @@ def person(id): db.session.execute( f"delete from person_refimg_link where person_id = {id}" ) Person.query.filter(Person.id==id).delete() db.session.commit() - return redirect( f'/persons' ) + return redirect( url_for( 'persons' ) ) elif request.form and form.validate(): new_refs=[] for ref_img in person.refimg: @@ -158,7 +158,7 @@ def person(id): st.AppendMessage(" To: ({}, {}, {})".format(person.tag, person.firstname, person.surname) ) db.session.add(person) db.session.commit() - return redirect( f'/person/{person.id}' ) + return redirect( url_for( 'person', id=person.id) ) except SQLAlchemyError as e: st.SetMessage( f"Failed to modify Person: {e}", "danger" ) return render_template("person.html", form=form, page_title=page_title)