From e07d6c462b73dc3f295cbdb31044a772dac479f7 Mon Sep 17 00:00:00 2001 From: Damien De Paoli Date: Wed, 22 Sep 2021 18:43:01 +1000 Subject: [PATCH] remember orig_url properly in OPT so that viewlist knows if we were originall import or storage for GetEntries to continue the list --- BUGs | 17 ----------------- TODO | 8 ++++++++ options.py | 1 + templates/viewer.html | 2 +- 4 files changed, 10 insertions(+), 18 deletions(-) diff --git a/BUGs b/BUGs index faf9245..433b0a3 100644 --- a/BUGs +++ b/BUGs @@ -3,22 +3,5 @@ BUG-56: when making a viewing list of AI:mich, (any search?) and going past the BUG-60: entries per page (in folders view) ignores pagesize, and this also contributes to BUG-56 I think BUG-61: in Fullscreen mode and next/prev occasionally dropped out of FS this is just another consequence of going beyond Pagesize, when we get new entries from DB, it loses FS flag -BUG-62: viewlist on venice subdir and 'next' crashes server with a 500 - ESC[36mpaweb |ESC[0m [2021-09-19 12:00:06,477] ERROR in app: Exception on /viewlist [POST] - ESC[36mpaweb |ESC[0m Traceback (most recent call last): - ESC[36mpaweb |ESC[0m File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2070, in wsgi_app - ESC[36mpaweb |ESC[0m response = self.full_dispatch_request() - ESC[36mpaweb |ESC[0m File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1515, in full_dispatch_request - ESC[36mpaweb |ESC[0m rv = self.handle_user_exception(e) - ESC[36mpaweb |ESC[0m File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1513, in full_dispatch_request - ESC[36mpaweb |ESC[0m rv = self.dispatch_request() - ESC[36mpaweb |ESC[0m File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1499, in dispatch_request - ESC[36mpaweb |ESC[0m return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args) - ESC[36mpaweb |ESC[0m File "/usr/local/lib/python3.8/dist-packages/flask_login/utils.py", line 272, in decorated_view - ESC[36mpaweb |ESC[0m return func(*args, **kwargs) - ESC[36mpaweb |ESC[0m File "/code/files.py", line 478, in viewlist - ESC[36mpaweb |ESC[0m current = int(lst[0]) - ESC[36mpaweb |ESC[0m ValueError: invalid literal for int() with base 10: '' - BUG-64: seems when we move files, then somehow this triggers a lot of md5/thumb action (just for the moved files?) as they get a new? FILE entry -- why do I do that if that is the case, the file, hash, thumb, faces, etc. should all still be connected to the FILE entry and just make it have a new home... diff --git a/TODO b/TODO index 0a2e94f..2c76b28 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,7 @@ ## GENERAL + * check for: 20180628_162833.jpg + -- thumb not rotated, presume its the if jpeg rotate code, so is this not a jpeg? + * ai search, should put 'all' at top of drop-down * when there is an actual error sent from B/E to F/E, you can't clear it other than deleting via sql @@ -31,6 +34,11 @@ * fix up logging in general * metadata at folder level with file level to add more richness + + * support animated gifs in html5 canvas + + * if a video is really mostly black, then we dont get a thumbnail... (see: 20210526_205257_01.mp4) + ## DB * Dir can have date in the DB, so we can do Oldest/Newest dirs in Folder view diff --git a/options.py b/options.py index 40043b4..afcf317 100644 --- a/options.py +++ b/options.py @@ -35,6 +35,7 @@ class Options(PA): url = request.form['orig_url'] else: url = request.path + self.orig_url=url if 'files_sp' in url: self.path_type = 'Storage' self.paths = SettingsSPath() diff --git a/templates/viewer.html b/templates/viewer.html index 131afc6..197f5aa 100644 --- a/templates/viewer.html +++ b/templates/viewer.html @@ -62,7 +62,7 @@ s+='' s+='' s+='' - s+='' + s+='' s+='' {% if search_term is defined %} s+=''