From a683da13cc11186bd51261e17ca46160cee89ef7 Mon Sep 17 00:00:00 2001 From: Damien De Paoli Date: Sun, 12 Oct 2025 23:49:35 +1100 Subject: [PATCH] gave whole of TODO a once over, removed old stuff --- TODO | 27 +++++++-------------------- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/TODO b/TODO index d88a745..2326d68 100644 --- a/TODO +++ b/TODO @@ -1,13 +1,3 @@ -### -# -# consider how to better version jscript - across all html files, consistently -# mtime, didnt work anyway, my phone still wont pick up the change, it was adding any ?v= changed this (once) -# -# 5 think I killed pa_job_manager without passing an eid to a transform job, shouldn't crash -# SHOULD JUST get AI to help clean-up and write defensive code here... -# -### - ### major fix - go to everywhere I call GetEntries(), and redo the logic totally... * client side: * for real chance to stop confusion, instead of removing deleted images from DOM, we should gray them out and put a big Del (red circle with line?) though it as overlay. @@ -20,8 +10,12 @@ * jobs for AI should show path name * rm dups job should show progress bar * in viewer, there is no move button (maybe add one?) + * think I killed pa_job_manager without passing an eid to a transform job, shouldn't crash + - SHOULD JUST get AI to help clean-up and write defensive code here... * consider doing duplicates before AI, and if there are say 100s+, then maybe pause the AI work - had 5000+ new photos, took 8 hours to finish, for me to just delete them anyway + * consider how to better version jscript - across all html files, consistently + - mtime, didnt work anyway, my phone still wont pick up the change, it was adding any ?v= changed this (once) * optimisation: - keep track of just new files since scan (even if we did this from the DB), then we could just feed those eid's explicitly into a 'get_file_details_on_new_files'. @@ -32,9 +26,7 @@ (is there a library for this???) * sqlalchemy 2 migration: - * fix unmapped (in fact make all the code properly sqlachemy 2.0 compliant) - -- path.py has the __allow_unmapped__ = True - * remove all '.execute' from *.py + - get AI to help * allow actions for wrong person: -> someone else? OR override no match for this person ever for this image? @@ -63,10 +55,6 @@ - rename (does this work already somehow? see issue below) - dont allow me to stupidly move a folder to itself - * browser back/forward buttons dont work -- use POST -> redirect to GET - - need some sort of clean-up of pa_user_state -- I spose its triggered by browser session, so maybe just after a week is lazy/good enough - - pa_user_state has last_used as a timestamp so can be used to delete old entries - * back button will fail if we do these POSTs: job.py:@app.route("/jobs", methods=["GET", "POST"]) job.py:@app.route("/job/", methods=["GET","POST"]) @@ -74,8 +62,8 @@ * if on jobs page and jobs increase, then 'rebuild' the content of the page to show new jobs, and potentially do that every 5 seconds... - THINK: could also 'refresh' /job/id via Ajax not a reload, to avoid the POST issue above needing to remember job prefs somewhere? - files.py:@app.route("/fix_dups", methods=["POST"]) - ??? + * files.py:@app.route("/fix_dups", methods=["POST"]) + - ??? * GUI overhaul? * on a phone, the files.html page header is a mess "Oldest.." line is too large to fit on 1 line (make it a hamburger?) @@ -110,7 +98,6 @@ * revisit SymlinkName() and make it simpler (see comment in shared.py) *** Need to use thread-safe sessions per Thread, half-assed version did not work - Admin -> do I want to have admin roles/users? -> purge deleted files (and associated DB data) needs a dbox or privs