ddp/photoassistant
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix BUG-66: deleting files out from under and in general CleanUpDirInDB needs to use Entry not Dir

Browse Source
This commit is contained in:
Damien De Paoli
2021-09-25 12:11:13 +10:00
parent 0b22072f53
commit 5abd01bb4d
3 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
BUGs
View File

@@ -5,11 +5,3 @@ BUG-61: in Fullscreen mode and next/prev occasionally dropped out of FS
this is just another consequence of going beyond Pagesize, when we get new entries from DB, it loses FS flag
BUG-64: seems when we move files, they get a new? FILE entry -- the file, hash, thumb, faces, etc. should all still be connected to the FILE entry and just make it have a new home / new location...
- this is both with a move via GUI, and theoretically also when we find a moved file on the FS (could use hash check to validate if we can just keep connections)
BUG-66: if I delete last image from a folder, OR, move the last image from a folder we don't try to clean it up? ALSO need to test when we do clean one up that theoretically has an empty parent after its deleted, etc.
-- deleted .xvpics in PROD, and its borked / cant import Camera Uploads at present
TEST:
Y - folder1/folder2/duplicate <- remove duplicate via rmdups
folder1/folder2/image <- remove via deleting image on underlying FS
folder1/folder2/image <- remove via deleting folder2/* on underlying FS
Do I want this functionality, it could remove the Camera-Uploads dir right? - folder1/folder2/image <- remove via move image to new folder
Do I want this functionality, it could remove the Camera-Uploads dir right? - folder1/folder2/image <- remove via deleting image in PA