ddp/books
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

added error handling for DB exceptions

Browse Source
This commit is contained in:
Damien De Paoli
2020-12-30 16:47:57 +11:00
parent 20c8bec8f5
commit e45e7633dd
1 changed files with 26 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
rating.py
View File

@@ -3,6 +3,7 @@ from flask import request, render_template, redirect
from flask_wtf import FlaskForm from flask_wtf import FlaskForm
from __main__ import db, app, ma from __main__ import db, app, ma
from sqlalchemy import func, Sequence from sqlalchemy import func, Sequence
from sqlalchemy.exc import SQLAlchemyError, IntegrityError
from status import st, Status from status import st, Status
################################################################################ ################################################################################
@@ -50,10 +51,16 @@ def new_rating():
return render_template("edit_id_name.html", form=form, page_title='Create new Rating' ) return render_template("edit_id_name.html", form=form, page_title='Create new Rating' )
else: else:
rating = Rating( name=request.form["name"] ) rating = Rating( name=request.form["name"] )
db.session.add(rating) try:
db.session.commit() db.session.add(rating)
st.SetMessage( "Created new Rating (id={})".format(rating.id) ) db.session.commit()
return redirect( '/ratings' ) st.SetAlert( "success" )
st.SetMessage( "Created new Rating (id={})".format(rating.id) )
return redirect( '/ratings' )
except SQLAlchemyError as e:
st.SetAlert( "danger" )
st.SetMessage( "<b>Failed to add rating:</b>&nbsp;{}".format( e.orig) )
return render_template("edit_id_name.html", form=form, page_title='Create new Rating', alert=st.GetAlert(), message=st.GetMessage() )
################################################################################ ################################################################################
# /rating/<id> -> GET/POST(save or delete) -> shows/edits/delets a single rating # /rating/<id> -> GET/POST(save or delete) -> shows/edits/delets a single rating
@@ -63,15 +70,21 @@ def rating(id):
### DDP: should this be request.form or request.values? ### DDP: should this be request.form or request.values?
form = RatingForm(request.form) form = RatingForm(request.form)
if request.method == 'POST' and form.validate(): if request.method == 'POST' and form.validate():
rating = Rating.query.get(id) try:
if 'delete' in request.form: rating = Rating.query.get(id)
st.SetMessage("Successfully deleted (id={}, name={})".format( rating.id, rating.name ) ) if 'delete' in request.form:
rating = Rating.query.filter(Rating.id==id).delete() st.SetMessage("Successfully deleted (id={}, name={})".format( rating.id, rating.name ) )
if 'submit' in request.form: rating = Rating.query.filter(Rating.id==id).delete()
st.SetMessage("Successfully Updated Rating (id={})".format(id) ) if 'submit' in request.form:
rating.name = request.form['name'] st.SetMessage("Successfully Updated Rating (id={})".format(id) )
db.session.commit() rating.name = request.form['name']
return redirect( '/ratings' ) db.session.flush()
db.session.commit()
return redirect( '/ratings' )
except SQLAlchemyError as e:
st.SetAlert( "danger" )
st.SetMessage( "<b>Failed to modity rating:</b>&nbsp;{}".format(e.orig) )
return render_template("edit_id_name.html", form=form, page_title='Edit Rating', alert=st.GetAlert(), message=st.GetMessage() )
else: else:
rating = Rating.query.get(id) rating = Rating.query.get(id)
form = RatingForm(request.values, obj=rating) form = RatingForm(request.values, obj=rating)