ddp/books
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

decided to number bugs and todo so I can link commits to their fixes

Browse Source
This commit is contained in:
Damien De Paoli
2020-12-31 12:18:32 +11:00
parent 868ad1379f
commit ddfd0b878b
2 changed files with 31 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
BUGs
View File

@@ -1,13 +1,16 @@
* loan card is not in right div anymore (since series stuff?)
BUG-1: loan card is not in right div anymore (since series stuff?)
http://mara.ddp.net:5000/book/1513
* series does not deal with calcd_rating...
BUG-2 series does not deal with calcd_rating...
(on edit could, recalc as a catch-all, and obviously if we change a single book's rating, we should re-calc)
* alter a condition, covertype, etc. and its not in drop-down list (even though db look via index is correct, e.g books.html shows updated covertype)
* show books, only shows first author
* starting on series remove button. If we click a subbook, then remove series button needs to be clever (might need client-side validation / confirmation, eg. this is a subbook, you want to remove all of the sub books from the series?)
* author,series, etc. do not have explicit ordering like sub-books... sort of irritating / needs code and DB fix
* add/remove authors, and after save they are ordered by author.id, not order of addition (prob. needs book_author_link to have an auth_num)
* if you remove a series from a book, it won't appear in the series drop-down if it is the first 'missing' book in that series -- either reset the list, or show all series always?
* if you add a sub-book, then fail to validate (say no genre), then it takes you back, you click a genre (BUT it has lost th eparent association), so it adds a book, not a sub-book
BUG-3 alter a condition, covertype, etc. and its not in drop-down list (even though db look via index is correct, e.g books.html shows updated covertype)
BUG-4 show books, only shows first author
BUG-6 author,series, etc. do not have explicit ordering like sub-books... sort of irritating / needs code and DB fix
* add/remove authors, and after save they are ordered by author.id, not order of addition (prob. needs book_author_link to have an auth_num)
BUG-7 if you remove a series from a book, it won't appear in the series drop-down if it is the first 'missing' book in that series -- either reset the list, or show all series always?
BUG-8 if you add a sub-book, then fail to validate (say no genre), then it takes you back, you click a genre (BUT it has lost th eparent association), so it adds a book, not a sub-book

39
README
View File

@@ -30,30 +30,29 @@ python3 main.py
### Remember:
MUST use form.errors when we have a validator that is fancier than not empty (year_published in book and num_books in series SO FAR)
### TODO:
- consider created/modifed for all fields? but mostly are they set via ORM for new books?
TODO-1 consider created/modifed for all fields? but mostly are they set via ORM for new books?
* No, not being set...
- need to delete 1 sub_book from book
TODO-2 need to delete 1 sub_book from book
* swap the 'add sub book' for 'remove from parent book' button and then act on it (separate route, simple sql exec and route back to (no-longer) child book)
(noting that deleting a child book already removes the book_sub_book_link)
- when remove a Parent book from a series, what do we do?
TODO-3 when remove a Parent book from a series, what do we do?
(remove all sub books from series too?)
- should deleting really just ask if want to mark it as SOLD?
- need to add books to loan (on loan page, and via a book search?)
- need to delete book from loan
- show books on shelf list
- show books to buy view / printable
- show unrated books (with toggle to exclude those with missing in a series)
- show books missing from a series (I own only some of them)
- show books on wish list
- show books that need replacing
- show books I have sold
- show books with poor rating
- view list of possible duplicate books by title
- consider which of the 'books maybe not valid' reports make sense still
TODO-4 with series remove - If we click a subbook, then remove series button needs to be clever (might need client-side validation / confirmation, eg. this is a subbook, you want to remove all of the sub books from the series?)
TODO-5 should deleting really just ask if want to mark it as SOLD?
TODO-6 need to add books to loan (on loan page, and via a book search?)
TODO-7 need to delete book from loan
TODO-8 show books on shelf list
TODO-9 show books to buy view / printable
TODO-11 show unrated books (with toggle to exclude those with missing in a series)
TODO-12 show books missing from a series (I own only some of them)
TODO-13 show books on wish list
TODO-14 show books that need replacing
TODO-15 show books I have sold
TODO-16 show books with poor rating
TODO-17 view list of possible duplicate books by title
TODO-18 consider which of the 'books maybe not valid' reports make sense still
(can you even have an N/A publisher now for example, but the genre one is interesting)
- icons for on wish list, etc.? (not sure I really want them, but if so)
TODO-19 icons on wish list, etc.? (not sure I really want them, but if so)
- wishlist: search-dollar OR https://www.flaticon.com/free-icon/wishlist_868517
- save: https://www.flaticon.com/free-icon/sold_463255?term=sold&page=1&position=6&related_item_id=463255
- with ORM: should I lazy load all books (ajax the 2nd->last pages in, or not use ORM, and do a quick db.execute()....)
TODO-20 ORM: should I lazy load all books (ajax the 2nd->last pages in, or not use ORM, and do a quick db.execute()....)