ddp/books
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

decided to number bugs and todo so I can link commits to their fixes

Browse Source
This commit is contained in:
Damien De Paoli
2020-12-31 12:18:32 +11:00
parent 868ad1379f
commit ddfd0b878b
2 changed files with 31 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
BUGs
View File

@@ -1,13 +1,16 @@
* loan card is not in right div anymore (since series stuff?)
BUG-1: loan card is not in right div anymore (since series stuff?)
http://mara.ddp.net:5000/book/1513
* series does not deal with calcd_rating...
BUG-2 series does not deal with calcd_rating...
(on edit could, recalc as a catch-all, and obviously if we change a single book's rating, we should re-calc)
* alter a condition, covertype, etc. and its not in drop-down list (even though db look via index is correct, e.g books.html shows updated covertype)
* show books, only shows first author
* starting on series remove button. If we click a subbook, then remove series button needs to be clever (might need client-side validation / confirmation, eg. this is a subbook, you want to remove all of the sub books from the series?)
* author,series, etc. do not have explicit ordering like sub-books... sort of irritating / needs code and DB fix
* add/remove authors, and after save they are ordered by author.id, not order of addition (prob. needs book_author_link to have an auth_num)
* if you remove a series from a book, it won't appear in the series drop-down if it is the first 'missing' book in that series -- either reset the list, or show all series always?
* if you add a sub-book, then fail to validate (say no genre), then it takes you back, you click a genre (BUT it has lost th eparent association), so it adds a book, not a sub-book
BUG-3 alter a condition, covertype, etc. and its not in drop-down list (even though db look via index is correct, e.g books.html shows updated covertype)
BUG-4 show books, only shows first author
BUG-6 author,series, etc. do not have explicit ordering like sub-books... sort of irritating / needs code and DB fix
* add/remove authors, and after save they are ordered by author.id, not order of addition (prob. needs book_author_link to have an auth_num)
BUG-7 if you remove a series from a book, it won't appear in the series drop-down if it is the first 'missing' book in that series -- either reset the list, or show all series always?
BUG-8 if you add a sub-book, then fail to validate (say no genre), then it takes you back, you click a genre (BUT it has lost th eparent association), so it adds a book, not a sub-book