ddp/books
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

added error handling for DB exceptions

Browse Source
This commit is contained in:
Damien De Paoli
2020-12-30 22:21:29 +11:00
parent db18edeef3
commit 60b7484afb
1 changed files with 24 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
genre.py
View File

@@ -3,6 +3,7 @@ from flask import request, render_template, redirect
from flask_wtf import FlaskForm from flask_wtf import FlaskForm
from __main__ import db, app, ma from __main__ import db, app, ma
from sqlalchemy import func, Sequence from sqlalchemy import func, Sequence
from sqlalchemy.exc import SQLAlchemyError
from status import st, Status from status import st, Status
################################################################################ ################################################################################
@@ -50,10 +51,15 @@ def new_genre():
return render_template("edit_id_name.html", form=form, page_title='Create new Genre' ) return render_template("edit_id_name.html", form=form, page_title='Create new Genre' )
else: else:
genre = Genre( name=request.form["name"] ) genre = Genre( name=request.form["name"] )
db.session.add(genre) try:
db.session.commit() db.session.add(genre)
st.SetMessage( "Created new Genre (id={})".format(genre.id) ) db.session.commit()
return redirect( '/genres' ) st.SetMessage( "Created new Genre (id={})".format(genre.id) )
return redirect( '/genres' )
except SQLAlchemyError as e:
st.SetAlert( "danger" )
st.SetMessage( "<b>Failed to add Genre:</b>&nbsp;{}".format( e.orig) )
return render_template("edit_id_name.html", form=form, page_title='Create new Genre', alert=st.GetAlert(), message=st.GetMessage() )
################################################################################ ################################################################################
# /genre/<id> -> GET/POST(save or delete) -> shows/edits/delets a single genre # /genre/<id> -> GET/POST(save or delete) -> shows/edits/delets a single genre
@@ -63,15 +69,20 @@ def genre(id):
### DDP: should this be request.form or request.values? ### DDP: should this be request.form or request.values?
form = GenreForm(request.form) form = GenreForm(request.form)
if request.method == 'POST' and form.validate(): if request.method == 'POST' and form.validate():
genre = Genre.query.get(id) try:
if 'delete' in request.form: genre = Genre.query.get(id)
st.SetMessage("Successfully deleted (id={}, name={})".format( genre.id, genre.name ) ) if 'delete' in request.form:
genre = Genre.query.filter(Genre.id==id).delete() st.SetMessage("Successfully deleted (id={}, name={})".format( genre.id, genre.name ) )
if 'submit' in request.form: genre = Genre.query.filter(Genre.id==id).delete()
st.SetMessage("Successfully Updated Genre (id={})".format(id) ) if 'submit' in request.form:
genre.name = request.form['name'] st.SetMessage("Successfully Updated Genre (id={})".format(id) )
db.session.commit() genre.name = request.form['name']
return redirect( '/genres' ) db.session.commit()
return redirect( '/genres' )
except SQLAlchemyError as e:
st.SetAlert( "danger" )
st.SetMessage( "<b>Failed to modity Genre:</b>&nbsp;{}".format(e.orig) )
return render_template("edit_id_name.html", form=form, page_title='Edit Genre', alert=st.GetAlert(), message=st.GetMessage() )
else: else:
genre = Genre.query.get(id) genre = Genre.query.get(id)
form = GenreForm(request.values, obj=genre) form = GenreForm(request.values, obj=genre)