ddp/books
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed bugs 9 & 10, just missing quotes in html for hidden value

Browse Source
This commit is contained in:
Damien De Paoli
2021-01-03 11:43:52 +11:00
parent 4ec84d1426
commit 4e4ff7f6c7
2 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
BUGs
View File

@@ -15,14 +15,3 @@ BUG-6: author,series, etc. do not have explicit ordering like sub-books... sort
BUG-7: if you remove a series from a book, it won't appear in the series drop-down if it is the first 'missing' book in that series -- either reset the list, or show all series always? BUG-7: if you remove a series from a book, it won't appear in the series drop-down if it is the first 'missing' book in that series -- either reset the list, or show all series always?
BUG-8: if you add a sub-book, then fail to validate (say no genre), then it takes you back, you click a genre (BUT it has lost th eparent association), so it adds a book, not a sub-book BUG-8: if you add a sub-book, then fail to validate (say no genre), then it takes you back, you click a genre (BUT it has lost th eparent association), so it adds a book, not a sub-book
### SHOWSTOPPERS: sub book issues, did the following steps:
BUG-9: raw DB error as blurb field is undefined -- seems the hidden fields at bottom of form are missing
BUG-10: raw DB error as blurb field is undefined -- we are not trapping this sort of DB error?
http://mara.ddp.net:5000/series/112
http://mara.ddp.net:5000/book/1282 (Mavin Manyshaped)
Add Sub-book -> BUG-9
then to test above, I:
created a new book
created a new sub-book
Saved it, and it added to Mavin Manyshaped parent book, not the new book -> BUG 10

2
templates/book.html
View File

@@ -207,7 +207,7 @@ function AddAuthorToBook(num) {
or key == 'condition' or key == 'blurb' ) %} or key == 'condition' or key == 'blurb' ) %}
{{book_form[key](class="form-control", rows=rows, disabled="disabled" )}} {{book_form[key](class="form-control", rows=rows, disabled="disabled" )}}
{# disabled fields do not come through in form post, so add hidden to make it work #} {# disabled fields do not come through in form post, so add hidden to make it work #}
<input type="hidden" name={{key}} value={{book_form[key].data}}> <input type="hidden" name="{{key}}" value="{{book_form[key].data}}">
{% else %} {% else %}
{{book_form[key](class="form-control", rows=rows )}} {{book_form[key](class="form-control", rows=rows )}}
{% endif %} {% endif %}